Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: Ghostty crash with window-step-resize and large initial window size #4801

Closed
mitchellh opened this issue Jan 8, 2025 · 0 comments · Fixed by #4851
Closed

macOS: Ghostty crash with window-step-resize and large initial window size #4801

mitchellh opened this issue Jan 8, 2025 · 0 comments · Fixed by #4851
Labels
crash Causes a crash, very high priority to fix os/macos
Milestone
1.1.0

Comments

@mitchellh
Copy link
Contributor

Discussed in #4755

Originally posted by pawelkata January 7, 2025

Details:

  • App version: 1.0.1 (1.0 installed from Homebrew, then updated from the in-app prompt to v1.0.1, build 8696),
  • MacOS version: Sequoia 15.2 on M1 Pro.

What's wrong?

  • Ghostty crashes while trying to open a new window either by keyboard shortcut or from the menu (tabs work).

Reproduction steps:

  1. Fire up Ghostty.
  2. Press CMD+N.
  3. Experience a crash.

Reproduction Config

font-size = 18
window-width = 120
window-height = 45
window-step-resize = true
@mitchellh mitchellh added crash Causes a crash, very high priority to fix os/macos labels Jan 8, 2025
@mitchellh mitchellh mentioned this issue Jan 9, 2025
Merged
mitchellh added a commit that referenced this issue Jan 9, 2025
@mitchellh
macos: improve initial size calculation (#4851)
a7c108a 
Fixes #4801

Our size calculation before improperly used a screens frame instead of
its visibleFrame. Additionally, we didn't properly account for origin
needing to move in order to fit the window on the screen.

Apparently, setting a frame height to high crashes AppKit. The width
gets clamped by AppKit but the height does not. Fun!
@github-actions github-actions bot added this to the 1.1.0 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash Causes a crash, very high priority to fix os/macos
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

macos: improve initial size calculation ghostty-org/ghostty
1 participant
@mitchellh