Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First obs_err_std is always equal to 1f0 #26

Closed
EhsanMehdipour opened this issue May 12, 2024 · 1 comment
Closed

First obs_err_std is always equal to 1f0 #26

EhsanMehdipour opened this issue May 12, 2024 · 1 comment

Comments

@EhsanMehdipour
Copy link

Hi Alex,

DINCAE.jl/src/data.jl

Line 92 in cec71e4

d[1].filename,d[1].varname,d[1].errvarname);

This line should change to:

        d[1].filename,d[1].varname,d[1].errvarname,
        obs_err_std = d[1].obs_err_std);

in case there is no errvarname.

Cheers,
Ehsan
Alexander-Barth added a commit that referenced this issue May 13, 2024
@Alexander-Barth
fix issue #26 (thanks @EhsanMehdipour)
3f41234
@Alexander-Barth
Copy link
Member

Yes, you are right, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alexander-Barth @EhsanMehdipour