Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light theme is not light enough #21

Closed
suhr opened this issue Dec 16, 2023 · 2 comments · Fixed by #45
Closed

Light theme is not light enough #21

suhr opened this issue Dec 16, 2023 · 2 comments · Fixed by #45

Comments

@suhr
Copy link
Contributor

suhr commented Dec 16, 2023

2023-12-16-201140_3840x2160_scrot

The input field is dark as well as code blocks.
@ggozad
Copy link
Owner

ggozad commented Dec 18, 2023

I am considering dropping the light/dark theme switcher altogether...
textual seems to have pretty limited support for theming and I am reluctant to put time and effort in maintaining one of my own.
Unless there are any takers?

@ggozad
Copy link
Owner

ggozad commented Jan 10, 2024

FYI related to Textualize/textual#3997

@ggozad ggozad mentioned this issue Jan 10, 2024
Merged
@ggozad ggozad linked a pull request Jan 10, 2024 that will close this issue
Patch TextArea and Markdown widgets to make them respond to theme changes. #45
Merged
@ggozad ggozad closed this as completed in abff8ba Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch TextArea and Markdown widgets to make them respond to theme changes. ggozad/oterm
2 participants
@suhr @ggozad