Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up guaranteed_format_features #6702

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Dec 11, 2024

Connections
Followup to #6690

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@atlv24 atlv24 requested a review from a team as a code owner December 11, 2024 09:36
@ErichDonGubler ErichDonGubler self-assigned this Dec 11, 2024
Copy link
Member

@ErichDonGubler ErichDonGubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, woot!

@ErichDonGubler ErichDonGubler changed the title Clean up guaranteed_format_features Clean up guaranteed_format_features Dec 11, 2024
@ErichDonGubler ErichDonGubler merged commit 22c8f8c into gfx-rs:trunk Dec 11, 2024
27 checks passed
@@ -3396,7 +3396,7 @@ impl TextureFormat {
#[must_use]
pub fn guaranteed_format_features(&self, device_features: Features) -> TextureFormatFeatures {
// Multisampling
let noaa = TextureFormatFeatureFlags::empty();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you see, this is supposed to represent the National Oceanic and Atmospheric Administration....

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants