Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update webgpu_sys to draft 2024-11-22 #6641

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

nolanderc
Copy link
Contributor

@nolanderc nolanderc commented Dec 2, 2024

uses version 0.2.97

Connections
See #6632, @cwfitzgerald wanted this update as a separate PR.

Description
One change in the IDL since the one previously used is the additions of multiple [Throws] attributes on some WebGPU functions. Previously, errors from JS were never caught, and simply propagated out of the WASM module (I'm not too familiar with the specifics). Now we have to handle these explicitly, as these functions now return a Result. For now, I just added calls to expect_throw to mimic the old behavior.

Also, in webgpu_sys, has now deprecated the old object.field(...) setters, and now uses the more explicit object.set_field(...).

Testing
There are no regressions in the old test suite.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
    • --target wasm32-unknown-emscripten
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cwfitzgerald cwfitzgerald merged commit 00625a7 into gfx-rs:trunk Dec 2, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants