refactor: warn on and satisfy clippy::{ptr_as_ptr,ref_as_ptr} in wgpu-{core,hal,types}
#6035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichDonGubler
force-pushed
the
ptr-cast-everywhere-plz
branch
from
0b5fb25 to
04d17a3
Compare
|
Ah… |
ErichDonGubler
force-pushed
the
ptr-cast-everywhere-plz
branch
2 times, most recently
from
c7b1f6a to
1eb54da
Compare
…gpu-{core,hal,types}`
…using `cargo +1.79.0 clippy --workspace --all-features --all-targets
--fix`, plus some manual changes to (1) catch some missed cases (not run
on all platforms?) and (2) `--fix` doesn't make things compile again. 😀
ErichDonGubler
force-pushed
the
ptr-cast-everywhere-plz
branch
from
1eb54da to
5ae19cb
Compare
ErichDonGubler
changed the title
wgpu-{core,hal}clippy::{ptr_as_ptr,ref_as_ptr} in wgpu-{core,hal,types}
nical
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for more details, which are intended to be merged via rebasing.
Connections
N/A
Description
I consider the title to be detail enough.
Testing
Things still compile and run!
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.Add change toLet's not plz.CHANGELOG.md. See simple instructions inside file.