From c2fddba45e9a742a586b74a3fd497b2b7df6901f Mon Sep 17 00:00:00 2001 From: Pierre Massat Date: Mon, 2 Oct 2023 13:13:05 -0400 Subject: [PATCH 1/2] feat: Release frame drop issue --- internal/occurrence/occurrence.go | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/internal/occurrence/occurrence.go b/internal/occurrence/occurrence.go index 9a672ae..c533138 100644 --- a/internal/occurrence/occurrence.go +++ b/internal/occurrence/occurrence.go @@ -87,7 +87,7 @@ const ( JSONDecodeType Type = 2003 RegexType Type = 2007 ViewType Type = 2006 - FrameDropType Type = 2008 + FrameDropType Type = 2009 FrameRegressionExpType Type = 2010 EvidenceNameDuration EvidenceName = "Duration" @@ -197,7 +197,11 @@ func NewOccurrence(p profile.Profile, ni nodeInfo) *Occurrence { } } -func FromRegressedFunction(p profile.Profile, regressed RegressedFunction, f frame.Frame) *Occurrence { +func FromRegressedFunction( + p profile.Profile, + regressed RegressedFunction, + f frame.Frame, +) *Occurrence { pf := p.Platform() switch pf { @@ -210,7 +214,11 @@ func FromRegressedFunction(p profile.Profile, regressed RegressedFunction, f fra fingerprint := fmt.Sprintf("%x", regressed.Fingerprint) beforeP95 := time.Duration(regressed.AggregateRange1).Round(10 * time.Microsecond) afterP95 := time.Duration(regressed.AggregateRange2).Round(10 * time.Microsecond) - regressionText := fmt.Sprintf("P95 function duration increased from %s to %s.", beforeP95, afterP95) + regressionText := fmt.Sprintf( + "P95 function duration increased from %s to %s.", + beforeP95, + afterP95, + ) return &Occurrence{ Culprit: fullyQualifiedName, From db3ae785674ad2bdd5fa3633bd0b1f294d81c1b9 Mon Sep 17 00:00:00 2001 From: Pierre Massat Date: Mon, 2 Oct 2023 13:15:51 -0400 Subject: [PATCH 2/2] Add a CHANGELOG entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 555784a..ba6907e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ **Features** - Return the first and deepest issue detected. ([#317](https://github.com/getsentry/vroom/pull/317)) +- Release frame drop issue detection. ([#329](https://github.com/getsentry/vroom/pull/329)) **Bug Fixes**