From e671fedfe149d4f3a0589bf739384be5a337c6b7 Mon Sep 17 00:00:00 2001 From: Tony Xiao Date: Mon, 2 Dec 2024 11:47:27 -0500 Subject: [PATCH] chore(metrics): Remove unused metrics summary kafka writer This was causing vroom to panic during shutdowns. --- cmd/vroom/main.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/cmd/vroom/main.go b/cmd/vroom/main.go index 385eca7..5127054 100644 --- a/cmd/vroom/main.go +++ b/cmd/vroom/main.go @@ -32,9 +32,8 @@ import ( type environment struct { config ServiceConfig - occurrencesWriter KafkaWriter - profilingWriter KafkaWriter - metricSummaryWriter KafkaWriter + occurrencesWriter KafkaWriter + profilingWriter KafkaWriter storage *blob.Bucket } @@ -97,10 +96,6 @@ func (e *environment) shutdown() { if err != nil { sentry.CaptureException(err) } - err = e.metricSummaryWriter.Close() - if err != nil { - sentry.CaptureException(err) - } sentry.Flush(5 * time.Second) }