From aad21aa5a024494c97604e41f77bf230582d59b8 Mon Sep 17 00:00:00 2001 From: Tony Xiao Date: Thu, 7 Nov 2024 16:31:47 -0500 Subject: [PATCH 1/2] fix(profiling): Should write the profiler id When writing the id to the functions table, we should be using the profiler id not the chunk id. This means all the ids before this PR are actually all wrong. --- cmd/vroom/kafka.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/vroom/kafka.go b/cmd/vroom/kafka.go index d0d1157..1c10d07 100644 --- a/cmd/vroom/kafka.go +++ b/cmd/vroom/kafka.go @@ -100,7 +100,7 @@ func buildChunkFunctionsKafkaMessage(c *chunk.SampleChunk, functions []nodetree. return FunctionsKafkaMessage{ Environment: c.Environment, Functions: functions, - ID: c.ID, + ID: c.ProfilerID, Platform: c.Platform, ProjectID: c.ProjectID, Received: int64(c.Received), From 07b159d74ec8721310a38b734c4e25131d8ff517 Mon Sep 17 00:00:00 2001 From: Tony Xiao Date: Thu, 7 Nov 2024 16:42:08 -0500 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 589efc6..6455658 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -48,6 +48,7 @@ - Increase readjob channel size ([#512](https://github.com/getsentry/vroom/pull/512)) - Return the duration measured by the profiler. ([#516](https://github.com/getsentry/vroom/pull/516), [#517](https://github.com/getsentry/vroom/pull/517)) - Annotate functions to the right thread. ([#523](https://github.com/getsentry/vroom/pull/523)) +- Should write the profiler id. ([#528](https://github.com/getsentry/vroom/pull/528)) **Internal**: