Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(integrations): remove deprecated project integration table #80148

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

ref(integrations): remove deprecated project integration table #80148

wants to merge 4 commits into from
+35 −78

Conversation

JoshFerge
Copy link
Member

this table has been deprecated for years. let's remove it.

Will make a follow up PR migration to delete the table as outlined here: https://develop.sentry.dev/backend/database-migrations/#deleting-tables

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

This PR has a migration; here is the generated SQL for src/sentry/migrations/0782_remove_project_integration_table_state.py ()

--
-- Custom state/database change combination
--
-- (no-op)

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
22904 5 22899 215
View the top 3 failed tests by shortest run time 
tests.sentry.backup.test_comparators test_default_comparators
Stack Traces | 0.492s run time 
#x1B[1m#x1B[.../sentry/backup/test_comparators.py#x1B[0m:2162: in test_default_comparators
    insta_snapshot(serialized)
#x1B[1m#x1B[31mE   Failed: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m
#x1B[1m#x1B[31mE   Snapshot .../snapshots/test_comparators/test_default_comparators.pysnap changed!#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Re-run pytest with SENTRY_SNAPSHOTS_WRITEBACK=new and then use 'make review-python-snapshots' to review.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Or: Use SENTRY_SNAPSHOTS_WRITEBACK=1 to update snapshots directly.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   --- #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   +++ #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   @@ -1063,12 +1063,6 @@#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE        - project_id#x1B[0m
#x1B[1m#x1B[31mE      model_name: sentry.projectdebugfile#x1B[0m
#x1B[1m#x1B[31mE    - comparators:#x1B[0m
#x1B[1m#x1B[31mE   -  - class: ForeignKeyComparator#x1B[0m
#x1B[1m#x1B[31mE   -    fields:#x1B[0m
#x1B[1m#x1B[31mE   -    - integration_id#x1B[0m
#x1B[1m#x1B[31mE   -    - project#x1B[0m
#x1B[1m#x1B[31mE   -  model_name: sentry.projectintegration#x1B[0m
#x1B[1m#x1B[31mE   -- comparators:#x1B[0m
#x1B[1m#x1B[31mE      - class: HashObfuscatingComparator#x1B[0m
#x1B[1m#x1B[31mE        fields:#x1B[0m
#x1B[1m#x1B[31mE        - public_key#x1B[0m
#x1B[1m#x1B[31mE   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m

tests.sentry.tasks.test_relocation.PreprocessingTransferTest test_success
Stack Traces | 3.21s run time 
#x1B[1m#x1B[.../sentry/tasks/test_relocation.py#x1B[0m:1043: in test_success
    self.insta_snapshot(cb_conf)
#x1B[1m#x1B[31mE   Failed: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m
#x1B[1m#x1B[31mE   Snapshot .../snapshots/PreprocessingTransferTest/test_success.pysnap changed!#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Re-run pytest with SENTRY_SNAPSHOTS_WRITEBACK=new and then use 'make review-python-snapshots' to review.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   Or: Use SENTRY_SNAPSHOTS_WRITEBACK=1 to update snapshots directly.#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   --- #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   +++ #x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE   @@ -91,7 +91,7 @@#x1B[0m
#x1B[1m#x1B[31mE   #x1B[0m
#x1B[1m#x1B[31mE      - -U#x1B[0m
#x1B[1m#x1B[31mE      - postgres#x1B[0m
#x1B[1m#x1B[31mE      - -c#x1B[0m
#x1B[1m#x1B[31mE   -  - TRUNCATE sentry_controloption,sentry_integration,sentry_option,sentry_organization,sentry_organizationintegration,sentry_organizationoptions,sentry_projecttemplate,sentry_projecttemplateoption,sentry_relay,sentry_relayusage,sentry_repository,sentry_team,auth_user,sentry_userip,sentry_userpermission,sentry_userrole,sentry_userrole_users,workflow_engine_dataconditiongroup,workflow_engine_datasource,workflow_engine_detector,workflow_engine_workflow,workflow_engine_workflowdataconditiongroup,workflow_engine_detectorworkflow,workflow_engine_datasourcedetector,workflow_engine_datacondition,sentry_savedsearch,sentry_recentsearch,sentry_project,sentry_orgauthtoken,sentry_organizationmember,sentry_organizationaccessrequest,sentry_monitor,sentry_groupsearchview,sentry_environment,sentry_email,sentry_datasecrecywaiver,sentry_dashboardtombstone,sentry_dashboard,sentry_customdynamicsamplingrule,sentry_projectcounter,sentry_authprovider,sentry_authidentity,auth_authenticator,sentry_apikey,sentry_apiapplication,sentry_useroption,sentry_useremail,sentry_snubaquery,sentry_sentryapp,sentry_rule,sentry_querysubscription,sentry_projectteam,sentry_projectredirect,sentry_projectownership,sentry_projectoptions,sentry_projectkey,sentry_projectintegration,sentry_projectbookmark,sentry_organizationmember_teams,sentry_notificationaction,sentry_neglectedrule,sentry_environmentproject,sentry_dashboardwidget,sentry_dashboardpermissions,sentry_customdynamicsamplingruleproject,sentry_apitoken,sentry_apigrant,sentry_apiauthorization,sentry_alertrule,sentry_snubaqueryeventtype,sentry_sentryappinstallation,sentry_sentryappcomponent,sentry_rulesnooze,sentry_ruleactivity,sentry_notificationactionproject,sentry_dashboardwidgetquery,sentry_alertruletrigger,sentry_alertruleprojects,sentry_alertruleexcludedprojects,sentry_alertruleactivity,sentry_alertruleactivationcondition,sentry_servicehook,sentry_incident,sentry_dashboardwidgetqueryondemand,sentry_alertruletriggerexclusion,sentry_alertruletriggeraction,sentry_timeseriessnapshot,sentry_pendingincidentsnapshot,sentry_incidenttrigger,sentry_incidentsubscription,sentry_incidentsnapshot,sentry_incidentactivity#x1B[0m
#x1B[1m#x1B[31mE   +  - TRUNCATE sentry_controloption,sentry_integration,sentry_option,sentry_organization,sentry_organizationintegration,sentry_organizationoptions,sentry_projecttemplate,sentry_projecttemplateoption,sentry_relay,sentry_relayusage,sentry_repository,sentry_team,auth_user,sentry_userip,sentry_userpermission,sentry_userrole,sentry_userrole_users,workflow_engine_dataconditiongroup,workflow_engine_datasource,workflow_engine_detector,workflow_engine_workflow,workflow_engine_workflowdataconditiongroup,workflow_engine_detectorworkflow,workflow_engine_datasourcedetector,workflow_engine_datacondition,sentry_savedsearch,sentry_recentsearch,sentry_project,sentry_orgauthtoken,sentry_organizationmember,sentry_organizationaccessrequest,sentry_monitor,sentry_groupsearchview,sentry_environment,sentry_email,sentry_datasecrecywaiver,sentry_dashboardtombstone,sentry_dashboard,sentry_customdynamicsamplingrule,sentry_projectcounter,sentry_authprovider,sentry_authidentity,auth_authenticator,sentry_apikey,sentry_apiapplication,sentry_useroption,sentry_useremail,sentry_snubaquery,sentry_sentryapp,sentry_rule,sentry_querysubscription,sentry_projectteam,sentry_projectredirect,sentry_projectownership,sentry_projectoptions,sentry_projectkey,sentry_projectbookmark,sentry_organizationmember_teams,sentry_notificationaction,sentry_neglectedrule,sentry_environmentproject,sentry_dashboardwidget,sentry_dashboardpermissions,sentry_customdynamicsamplingruleproject,sentry_apitoken,sentry_apigrant,sentry_apiauthorization,sentry_alertrule,sentry_snubaqueryeventtype,sentry_sentryappinstallation,sentry_sentryappcomponent,sentry_rulesnooze,sentry_ruleactivity,sentry_notificationactionproject,sentry_dashboardwidgetquery,sentry_alertruletrigger,sentry_alertruleprojects,sentry_alertruleexcludedprojects,sentry_alertruleactivity,sentry_alertruleactivationcondition,sentry_servicehook,sentry_incident,sentry_dashboardwidgetqueryondemand,sentry_alertruletriggerexclusion,sentry_alertruletriggeraction,sentry_timeseriessnapshot,sentry_pendingincidentsnapshot,sentry_incidenttrigger,sentry_incidentsubscription,sentry_incidentsnapshot,sentry_incidentactivity#x1B[0m
#x1B[1m#x1B[31mE        RESTART IDENTITY CASCADE;#x1B[0m
#x1B[1m#x1B[31mE      id: clear-database#x1B[0m
#x1B[1m#x1B[31mE      name: gcr.io/cloud-builders/docker#x1B[0m
#x1B[1m#x1B[31mE   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#x1B[0m

tests.sentry.backup.test_releases.ReleaseTests test_at_head
Stack Traces | 50.6s run time 
#x1B[1m#x1B[.../sentry/backup/test_releases.py#x1B[0m:90: in test_at_head
    self.insta_snapshot(
#x1B[1m#x1B[.../testutils/pytest/fixtures.py#x1B[0m:261: in inner
    is_unequal = inequality_comparator(refval, output)
#x1B[1m#x1B[.../sentry/backup/test_releases.py#x1B[0m:55: in snapshot_inequality_comparator
    result = validate(refval_json, output_json, get_default_comparators())
#x1B[1m#x1B[.../sentry/backup/validate.py#x1B[0m:183: in validate
    left_models, left_ordinal_counters = build_model_map(left_data, Side.left, findings)
#x1B[1m#x1B[.../sentry/backup/validate.py#x1B[0m:108: in build_model_map
    raise RuntimeError("Unknown model class")
#x1B[1m#x1B[31mE   RuntimeError: Unknown model class#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@getsantry
Copy link
Contributor

getsantry bot commented Nov 23, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoshFerge