-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of resolve
library
#12860
Labels
Comments
AbhiPrasad
added
Type: Improvement
Package: nextjs
Issues related to the Sentry Nextjs SDK
Meta: Good First Issue
labels
Jul 10, 2024
This eliminates 5 deps / 225 KB from the dep tree of the SDK: https://npmgraph.js.org/?q=resolve |
Looks like this does need esm resolution support! We might need https://github.com/unjs/mlly instead |
just a heads up @AbhiPrasad, 5 deps: https://npmgraph.js.org/?q=mlly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Problem Statement
sentry-javascript/packages/nextjs/package.json
Line 83 in 3549777
The SDK requires Node
14.18+
as persentry-javascript/packages/nextjs/package.json
Line 10 in 3549777
This means we can replace
resolve
library with native Node.js usage.Solution Brainstorm
Instead of using resolve, we can useimport { createRequire } from 'module';
. This is fine because we only need CJS resolution here.See rollup/plugins#1742 as an example PR doing this.The text was updated successfully, but these errors were encountered: