Skip to content

Commit

Permalink
fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
mydea committed Nov 29, 2024
1 parent b0e8395 commit 56e5720
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 2 additions & 1 deletion packages/browser-utils/src/instrument/dom.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ export function instrumentDOM(): void {
const targetObj = globalObject[target];
const proto = targetObj && targetObj.prototype;

if (!proto || Object.prototype.hasOwnProperty.call(proto, 'addEventListener')) {
// eslint-disable-next-line no-prototype-builtins
if (!proto || !proto.hasOwnProperty || !proto.hasOwnProperty('addEventListener')) {
return;
}

Expand Down
3 changes: 1 addition & 2 deletions packages/core/src/metrics/aggregator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ export class MetricsAggregator implements MetricsAggregatorBase {
// that we store in memory.
private _bucketsTotalWeight;

// Cast to any so that it can use Node.js timeout
private readonly _interval: ReturnType<typeof setInterval>;
private readonly _interval: ReturnType<typeof setInterval> & { unref?: () => void };

// SDKs are required to shift the flush interval by random() * rollup_in_seconds.
// That shift is determined once per startup to create jittering.
Expand Down

0 comments on commit 56e5720

Please sign in to comment.