Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit profiles when transaction was sampled #4280

Open
jjbayer opened this issue Nov 22, 2024 · 0 comments · May be fixed by #4195
Open

Rate limit profiles when transaction was sampled #4280

jjbayer opened this issue Nov 22, 2024 · 0 comments · May be fixed by #4195

Comments

@jjbayer
Copy link
Member

jjbayer commented Nov 22, 2024

When a transaction is dropped by dynamic sampling, the profile lives on without the transaction. However, such a profile does not get dropped by rate limits.

This draft PR contains a test that demonstrates the desired behavior: #4195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant