Adds influxdb v2 query runner. #6646
Conversation
- Adds test cases - Adds influxdb v2 icon - Updates python dependencies
|
Hi @fabrei, Thanks for the PR. |
Oh yes. Sorry, I didn't notice the linting and formatting check in test env. I fixed it :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6646 +/- ##
==========================================
+ Coverage 62.57% 62.77% +0.19%
==========================================
Files 161 162 +1
Lines 13184 13261 +77
Branches 1797 1805 +8
==========================================
+ Hits 8250 8324 +74
- Misses 4649 4651 +2
- Partials 285 286 +1
|
There was a problem hiding this comment.
@fabrei Regarding updates, it looks good from my end.
Did you run a manual test? I don't have InfluxDB2 env. So, I will rely on the results of your manual tests.
And please add "InfluxDB2" (I don't know a formal name) in https://github.com/getredash/redash#supported-data-sources.
Yes, I tested the query runner manually with an influx database version 2. I tested it, with and without using ssl. It worked fine for me.
I added it, but used "InfluxDBv2", so that it's clear, that it's a query runner for influx database version 2. |
There was a problem hiding this comment.
@fabrei Thanks for your reply. It is okay from my end.
@guidopetri Please review this PR if you have some time.
|
Is there any ETA when this will be in the docker builds? I wanted to switch from grafana to redash but we need Influx v2 support |
|
@TobiasGrether This is in |
|
There were no issues in |
What type of PR is this?
Description
It uses influxdb-client python library which is compatible with influxdb v2.
It supports ssl connection to influxdb as well.
How is this tested?
Related Tickets & Documents
#5391
Mobile & Desktop Screenshots/Recordings (if there are UI changes)