Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State should be case sensitive and follow the exact spelling #31

Open
andy-shev opened this issue Nov 14, 2018 · 1 comment
Open

State should be case sensitive and follow the exact spelling #31

andy-shev opened this issue Nov 14, 2018 · 1 comment

Comments

@andy-shev
Copy link

andy-shev commented Nov 14, 2018

When run git pw patch update --state <STATE> I have to provide an exact spelling of the <STATE> in question. However, when I got information about current state (either via git pw path list or looking at the result page from git pw patch update --state <STATE>) I see it spelled wrong.

First attempt:

% git pw patch update 993589 --state superseeded # **UPDATE** typo is here!

{u'state': [u'Invalid state superseeded. Expected one of: New, Under Review, Accepted, Rejected, RFC, Not Applicable, Changes Requested, Awaiting Upstream, Superseded, Deferred, Needs Review / ACK.']}

Second attempt:

% git pw patch update 993589 --state Superseded
| State      | superseded                                                              |

P.S. Under Review is spelled as under-review inside the tool which is wrong. pwclient doesn't have such issue.

@andy-shev
Copy link
Author

Ah, I made a typo, so, it works, but makes the view inconsistent. So, consider this as an enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant