Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example header has semicolons, twig template does not. #38

Open
dcrobertson01 opened this issue Aug 1, 2019 · 0 comments
Open

Example header has semicolons, twig template does not. #38

dcrobertson01 opened this issue Aug 1, 2019 · 0 comments

Comments

@dcrobertson01
Copy link

Hi - nice work on the slider. Just installed and playing about with it a little.

I am using a slider type of 'text' and the demo header information from the read me and the skeleton.

I notice these files have the following options:

type_text_vertical_padding: 70px;
type_text_horizontal_padding: 50px;

Using the provided template, this gives:

<div class="panel-padding " style=" padding: 70px; 50px; ">
Which causes an error.

Removing the semi-colons from the header, and changing the twig file from:

<div class="panel-padding {{ settings.type_text_css_class }}" style="
padding: {{ settings.type_text_vertical_padding|default(0) }} {{ settings.type_text_horizontal_padding|default(0) }}
">

to:

<div class="panel-padding {{ settings.type_text_css_class }}" style="
padding: {{ settings.type_text_vertical_padding|default(0) }} {{ settings.type_text_horizontal_padding|default(0) }};
">
(eg. adding a semicolon to the end of the second line. Or third line as rendered here )
seems to work without complications.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant