Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: update test suite for WooCommerce 8.3 Cart and Checkout Blocks #2090

Merged
merged 23 commits into from
Nov 22, 2023

Conversation

shashwatahalder01
Copy link
Contributor

@shashwatahalder01 shashwatahalder01 commented Nov 22, 2023

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

update: update tests for new woocommerce cart and checkout blocks
add: add announcement notice API tests
add: add withdraw charge API tests

Related Pull Request(s)

  • Full PR Link

Closes

  • Closes #

How to test the changes in this Pull Request:

  • Steps or issue link

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced announcement management with updated hover actions for restoring and deleting announcements.
    • Improved cart functionality with a new method for checking product visibility and updated API endpoints for item removal.
    • Added new endpoints for managing withdrawal charges in the API.
    • Introduced a new payload for withdrawal transactions.
  • Bug Fixes

    • Corrected test descriptions for better clarity and grammatical accuracy.
    • Activated previously skipped tests for announcement management.
  • Documentation

    • Updated selectors to reflect changes in the UI structure, ensuring accurate interactions with elements.
  • Chores

    • Removed unused code related to environment variable management in authentication tests.

@shashwatahalder01 shashwatahalder01 added the Needs: Dev Review It requires a developer review and approval label Nov 22, 2023
@shashwatahalder01 shashwatahalder01 self-assigned this Nov 22, 2023
@nurul-umbhiya nurul-umbhiya merged commit 86c55f4 into getdokan:develop Nov 22, 2023
2 checks passed
@shashwatahalder01 shashwatahalder01 added the QA approved This PR is approved by the QA team label Sep 25, 2024
Copy link
Contributor

coderabbitai bot commented Sep 25, 2024

Warning

Rate limit exceeded

@shashwatahalder01 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 5 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between 321ea9a and f79479f.

Walkthrough

The pull request introduces multiple changes across various test files and utility functions. Key modifications include updates to selectors for UI elements, adjustments in test logic for announcements, enhancements to API endpoint definitions, and the addition of new properties in data structures. These changes collectively improve the handling of announcements, customer interactions, and withdrawal processes within the application.

Changes

File Change Summary
tests/pw/pages/announcementsPage.ts Updated hover actions for announcements to use a new selector.
tests/pw/pages/customerPage.ts Modified clearCart method for updated selectors and API endpoint changes. Adjusted success message and added focus on placeOrder before clicking.
tests/pw/pages/proPromoPage.ts Introduced conditional logic for checking visibility of the promotional banner.
tests/pw/pages/selectors.ts Multiple selector updates reflecting changes in the UI structure for promotions, announcements, cart items, and payment methods.
tests/pw/tests/api/announcements.spec.ts Added announcementNoticeId variable, updated test descriptions for grammatical correctness, and activated previously skipped tests.
tests/pw/tests/api/rankMath.spec.ts Changed a test case to be skipped unconditionally.
tests/pw/tests/api/withdraws.spec.ts Introduced two new skipped test cases for withdrawal methods due to unmerged features.
tests/pw/tests/e2e/_auth.setup.spec.ts Removed a line related to writing VENDOR2_ID to an environment file.
tests/pw/tests/e2e/announcements.spec.ts Renamed and modified test cases for creating and managing announcements, including changes to how announcements are created and deleted.
tests/pw/utils/apiEndPoints.ts Added new endpoints for retrieving withdrawal method charges.
tests/pw/utils/dbData.ts Introduced withdraw_charges property with payment method details.
tests/pw/utils/payloads.ts Added a new payload entry for withdrawal charges.
tests/pw/utils/testData.ts Added a new property store related to WooCommerce API.

Possibly related PRs

  • Add Api tests, Fix coverage issue #2376: This PR adds coverage tags for API endpoints related to announcements, which aligns with the changes in the main PR that modify how announcements are handled in the UI, particularly regarding hover actions for announcement cells.
  • add privacy policy tests (automation suite) #2378: This PR includes changes to the PrivacyPolicyPage class, which involves modifications in the navigation and visibility checks. While not directly related to the announcement functionality, it reflects similar UI interaction improvements that could be relevant in a broader context of UI testing and interaction.

Suggested labels

Ready to Merge, Upcoming Release, :+1: Dev Review Done

Suggested reviewers

  • mrabbani

Poem

🐰 In the meadow where changes bloom,
Announcements dance, dispelling gloom.
With selectors bright and tests anew,
The rabbit hops, all thanks to you!
In code we trust, our paths align,
Hooray for updates, all will be fine! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shashwatahalder01 shashwatahalder01 removed the Needs: Dev Review It requires a developer review and approval label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved This PR is approved by the QA team Test Automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants