Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dashboard Menu Manager #2050

Merged

Conversation

aihimel
Copy link
Contributor

@aihimel aihimel commented Oct 17, 2023

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

Closes

How to test the changes in this Pull Request:

Changelog entry

Title

Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@aihimel aihimel self-assigned this Oct 17, 2023
@nurul-umbhiya
Copy link
Contributor

@aihimel bhai what is the status of this PR?

@aihimel aihimel added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Nov 3, 2023
@nurul-umbhiya nurul-umbhiya added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Nov 7, 2023
@Mohaiminulislam1989
Copy link
Contributor

@StalinDurjo please check again if this pr fix the bug.

@StalinDurjo
Copy link
Contributor

@Mohaiminulislam1989 bhai working on it, will let you know once done.

@Mohaiminulislam1989
Copy link
Contributor

Thank you

@StalinDurjo
Copy link
Contributor

@Mohaiminulislam1989 Bhai, for some reason the code is not working on our devices. Aftab bhai has checked the issue and is looking into it.

@nurul-umbhiya nurul-umbhiya changed the title Dashboard Menu Manager Feature: Dashboard Menu Manager Jan 23, 2024
@Mohaiminulislam1989
Copy link
Contributor

Any update?

@aihimel aihimel added Needs: Testing This requires further testing and removed Type: Bug labels Jan 26, 2024
@Aunshon Aunshon force-pushed the develop branch 2 times, most recently from 74f8fc3 to e63971a Compare January 29, 2024 11:13
includes/Shortcodes/Dashboard.php Outdated Show resolved Hide resolved
src/admin/pages/Settings.vue Outdated Show resolved Hide resolved
* Typo fixed
* filter name changed
* Translation issue fixed
@StalinDurjo StalinDurjo added QA approved This PR is approved by the QA team and removed Needs: Testing This requires further testing labels Feb 20, 2024
@nurul-umbhiya nurul-umbhiya merged commit 2cba3d3 into getdokan:develop Feb 28, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependency With Pro QA approved This PR is approved by the QA team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants