-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the exclusive keyword #45
base: main
Are you sure you want to change the base?
Conversation
Thanks for the fast work @mattiagiupponi ! |
The keyword - 'Subsite_exclusive' is working for documents, maps, datasets!! |
great!
@gannebamm please let me know when your tests are done so I can merge the PR |
Hi, As can be seen in the screen shot, the map (subsite_exclusive_test_map) and its related data set (subsite_exclusive_test_data) |
Hi @gannebamm @vineetasharma105 |
I just deployed the changes and they do not work as intended, yet. See: https://geonode-demo.thuenen.de/holisoils/catalogue/uuid/6e60d107-3643-4ce5-9482-e098ad4e9305 The map is subsite exlusive, belongs to the holisoils group and uses only subsite ressources. It seems all ressources which are subsite_exclusive currently fail with: We used these subsite specific variables: # SUBSITE SPECIFIC CONFIGURATION
ENABLE_SUBSITE_CUSTOM_THEMES = True
ENABLE_CATALOG_HOME_REDIRECTS_TO = False
SUBSITE_READ_ONLY = False # return download_resourcebase and view resourcebase as permissions
SUBSITE_HIDE_EXCLUSIVE_FROM_SPECIFIC_API = True # If TRUE will hide the `subsite_exclusive` resources also from the detailed endpoint `/documents`, `/maps`, `/datasets`, '/geoapps` The code is using 270c349 Did we misconfigure something? |
Can you try by set |
redeployed.
This will fix the [ "Subsite not found" ] issue but the links still point to the main portal. https://geonode-demo.thuenen.de/holisoils/catalogue/#/maps?d=57%3Bmap |
uhm is working fine on my test environment with or without that variable, i'll give another check soon |
Just as additional info: |
Hi @gannebamm But the API v2 is returning the linked resources as expected by adding the subsite: While on my local instance using geonode-master and mapstore-client-master is working as expected: I notice that the mapstore-client used by the project, is a fork of the 52north mapstore client fork which is about 20 commits behind the production one for GeoNode 4.3.x which also includes improvement for the linked resources (GeoNode/geonode-mapstore-client@c7f6d10) Can you please evaluate to upgrade the mapstore client and align it to the GeoNode one? So we can have the same environment. |
@mattiagiupponi Thank you very much for the in-depth look! Yes, we will upgrade soon. See: Thuenen-GeoNode-Development/thuenen_atlas#58 (comment) |
ref #44