Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CI/CD using Github Actions #41

Merged
merged 11 commits into from
Oct 25, 2024
Merged

Conversation

mo3rfan
Copy link
Contributor

@mo3rfan mo3rfan commented Sep 5, 2024

Had to fix the backend Dockerfile and helper scripts to ensure the tests run. However the unit tests had some failure that I didn't check further.

To check the github actions runs, you can find it on my fork: https://github.com/mo3rfan/digital-twin-toolbox/actions

Ref: #33

@mo3rfan mo3rfan self-assigned this Sep 5, 2024
@mo3rfan mo3rfan marked this pull request as ready for review September 5, 2024 16:42
@mo3rfan mo3rfan requested a review from allyoucanmap September 5, 2024 16:42
@tdipisa tdipisa requested review from randomorder and removed request for allyoucanmap September 16, 2024 12:12
@tdipisa tdipisa added this to the v1.0.0 milestone Sep 16, 2024
@tdipisa tdipisa added internal This mark worked required as internal work CI/CD labels Sep 16, 2024
@tdipisa
Copy link
Member

tdipisa commented Sep 16, 2024

However the unit tests had some failure that I didn't check further.

@allyoucanmap this part if for you to review, I guess.

@tdipisa tdipisa linked an issue Sep 30, 2024 that may be closed by this pull request
@allyoucanmap
Copy link
Contributor

@tdipisa @mo3rfan I just merged the main branch on this PR to check if the fixes on tests and build are working

@allyoucanmap
Copy link
Contributor

@tdipisa @mo3rfan now there is another problem but it does not seems related to tests, it's saying no space left on device

https://github.com/mo3rfan/digital-twin-toolbox/actions/runs/11251898787

@mo3rfan
Copy link
Contributor Author

mo3rfan commented Oct 9, 2024

Tests are working now: https://github.com/mo3rfan/digital-twin-toolbox/actions/runs/11253236378/job/31292329536
Thanks for the fix @allyoucanmap

Few things I need to do two things before we merge this:

  • Move the github custom runner to this repository.
  • Set the dockerhub credentials to this repository.

@mo3rfan
Copy link
Contributor Author

mo3rfan commented Oct 9, 2024

I don't think I have the credentials or permission to get the geosolutions dockerhub tokens. @tdipisa or @randomorder We need to add two repository secrets here:

  • DOCKERHUB_USERNAME
  • DOCKERHUB_TOKEN

This token should have permission to push to both:

Eitherway, we can merge this PR now. The deployment job that will fail can be re-run at anytime after the above token is set.

@tdipisa
Copy link
Member

tdipisa commented Oct 9, 2024

@tdipisa or @randomorder We need to add two repository secrets here:

That's for you @randomorder

@randomorder
Copy link
Member

@tdipisa or @randomorder We need to add two repository secrets here:

That's for you @randomorder

Secrets are in place. Go ahead and test it again please @mo3rfan before merging

@mo3rfan
Copy link
Contributor Author

mo3rfan commented Oct 21, 2024

@allyoucanmap The latest version of micromamba has broken the build again.

Breaking change: https://mamba.readthedocs.io/en/latest/developer_zone/changes-2.0.html#micromamba

It's best to pin the version of micromamba in the backend's Dockerfile.

@allyoucanmap
Copy link
Contributor

@mo3rfan but it should be already forced to the version 1.5.10 https://github.com/geosolutions-it/digital-twin-toolbox/blob/main/backend/Dockerfile#L28. Is the branch aligned to main?

@mo3rfan
Copy link
Contributor Author

mo3rfan commented Oct 21, 2024

@mo3rfan but it should be already forced to the version 1.5.10 https://github.com/geosolutions-it/digital-twin-toolbox/blob/main/backend/Dockerfile#L28. Is the branch aligned to main?

Thanks for pointing out, I will rebase over those changes.

also wanted to test cache effectiveness in this run
@mo3rfan
Copy link
Contributor Author

mo3rfan commented Oct 21, 2024

Builds are functional: https://github.com/geosolutions-it/digital-twin-toolbox/actions/runs/11441453209/job/31831496187?pr=41

Tested docker login with credentials: https://github.com/mo3rfan/digital-twin-toolbox/actions/runs/11441036990/job/31829327202#step:2:9

Also increased the space under /var logical volume on self-hosted runner so we don't encounter more space issues with builds on docker.

@allyoucanmap allyoucanmap merged commit 1033f39 into geosolutions-it:main Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD internal This mark worked required as internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Digital Twin CI/CD workflow
4 participants