Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create index from single document #1073

Merged
merged 5 commits into from
Sep 8, 2023
Merged

fix: create index from single document #1073

merged 5 commits into from
Sep 8, 2023

Conversation

jiashenC
Copy link
Member

@jiashenC jiashenC commented Sep 8, 2023

Use a runtime row_number to build the index by incorporating design discussions from #912 and #868.

@jiashenC
Copy link
Member Author

jiashenC commented Sep 8, 2023

@aryan-rajoria Please pull this branch to test if issue of creating index from single PDF is fixed.

@xzdandy
Copy link
Collaborator

xzdandy commented Sep 8, 2023

Not relevant to this PR. Are we still having incorrect links in documentation?

sphinx.errors.SphinxWarning: /home/circleci/project/docs/source/overview/concepts.rst:57:broken link: https://github.com/georgia-tech-db/evadb/blob/master/evadb/udfs/mnist_image_classifier.py (404 Client Error: Not Found for url: https://github.com/georgia-tech-db/evadb/blob/master/evadb/udfs/mnist_image_classifier.py)

@jiashenC
Copy link
Member Author

jiashenC commented Sep 8, 2023

Not relevant to this PR. Are we still having incorrect links in documentation?

sphinx.errors.SphinxWarning: /home/circleci/project/docs/source/overview/concepts.rst:57:broken link: https://github.com/georgia-tech-db/evadb/blob/master/evadb/udfs/mnist_image_classifier.py (404 Client Error: Not Found for url: https://github.com/georgia-tech-db/evadb/blob/master/evadb/udfs/mnist_image_classifier.py)

Probably because I haven't rebased with staging. Let me sync with it.

@xzdandy xzdandy added the Bug 🐞 EVA is not working as expected label Sep 8, 2023
@xzdandy xzdandy added this to the v0.3.5 milestone Sep 8, 2023
@jiashenC jiashenC merged commit f0dd533 into staging Sep 8, 2023
@jiashenC jiashenC deleted the fix-create-index branch September 8, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 EVA is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants