Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arithmetic expression support in Parser #1093

Open
1 of 2 tasks
xzdandy opened this issue Sep 11, 2023 · 2 comments
Open
1 of 2 tasks

Arithmetic expression support in Parser #1093

xzdandy opened this issue Sep 11, 2023 · 2 comments
Labels
Feature Request ✨ New feature or request User Experience
Milestone
Long Term Goal

Comments

@xzdandy
Copy link
Collaborator

xzdandy commented Sep 11, 2023 •
edited
Loading

Search before asking

  • I have searched the EvaDB issues and found no similar feature requests.

Description

Currently, EvaDB does not have arithmetic expression support in https://github.com/georgia-tech-db/evadb/blob/staging/evadb/parser/lark_visitor/_expressions.py. So expression in projection or predicate with arithmetic operations does not work. Simple query to test:

SELECT 1+2;

Use case

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@xzdandy xzdandy added the Feature Request ✨ New feature or request label Sep 11, 2023
@xzdandy xzdandy added this to the Long Term Goal milestone Sep 22, 2023
@aayushacharya
Copy link

Hi, may I work on this feature?

aayushacharya added a commit to aayushacharya/evadb that referenced this issue Feb 7, 2024
@aayushacharya
feat: added arithmetic expression support, closes georgia-tech-db#1093
287ca98
aayushacharya added a commit to aayushacharya/evadb that referenced this issue Feb 7, 2024
@aayushacharya
feat: added arithmetic expression support, closes georgia-tech-db#1093
bdeecaf
@aayushacharya
Copy link

I have added PR #1444 corresponding to this feature. I would love to get feedback if changes need to be made. The supported operations in precedence are:

  1. Multiplication *, Division / and Modulo %
  2. Addition + and Subtraction -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request ✨ New feature or request User Experience
Projects
EVA Public Roadmap ⚡🚀
Status: ToDo
Milestone
Long Term Goal
Development

No branches or pull requests
2 participants
@xzdandy @aayushacharya