Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model training raises error with ludwig #1071

Closed
1 of 2 tasks
gaurav274 opened this issue Sep 7, 2023 · 2 comments
Closed
1 of 2 tasks

Model training raises error with ludwig #1071

gaurav274 opened this issue Sep 7, 2023 · 2 comments
Assignees
@hershd23
Labels
Bug 🐞 EVA is not working as expected
Milestone
v0.3.5

Comments

@gaurav274
Copy link
Member

Search before asking

  • I have searched the EvaDB issues and found no similar bug report.

Bug

The keyword Ludwig should not be case-sensitive.

Does not work when passed ludwig

Environment

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@hershd23
Copy link
Contributor

hershd23 commented Sep 8, 2023

Hey, can I take this?

@hershd23 hershd23 mentioned this issue Sep 11, 2023
Merged
@xzdandy xzdandy added this to the v0.3.5 milestone Sep 12, 2023
@xzdandy xzdandy added the Bug 🐞 EVA is not working as expected label Sep 12, 2023
gaurav274 pushed a commit that referenced this issue Sep 12, 2023
@hershd23
Making Ludwig and HuggingFace case insensitive (#1090)
e48729f 
Lowercasing function_type and target string before matching so as to make it case-insensitive

	modified:   evadb/binder/statement_binder.py
	modified:   evadb/executor/create_function_executor.py
	
Although #1071 discusses only `Ludwig`, I saw the same behavior in the
case of `HuggingFace` as well and made that case insensitive as well
@hershd23
Copy link
Contributor

This is solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hershd23 hershd23

Labels
Bug 🐞 EVA is not working as expected
Projects
None yet
Milestone
v0.3.5
Development

No branches or pull requests
3 participants
@xzdandy @gaurav274 @hershd23