Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select requires a title on the mapsource layer #651

Open
brentfraser opened this issue May 25, 2021 · 3 comments
Open

Select requires a title on the mapsource layer #651

brentfraser opened this issue May 25, 2021 · 3 comments

Comments

@brentfraser
Copy link
Contributor

The "Select from" drop down combo box contains a list of selectable layers when the user is doing a "select" operation. The list of names is populated from the mapsource->layer->title (if any), not the Catalog->layer-title. Currently if the mapsource->layer->title doesn't exist, the combo box has a blank entry.

I think the rule should be to use the first found of:

  • Catalog->layer-title
  • mapsource->layer->title
  • mapsource->layer->name
@klassenjs
Copy link
Member

I don't think Catalog->layer->title is doable because catalog layers are many-to-many (and not one-to-one) with mapsource layers and the mapsource layers are what is actually queryable.

Although, IIRC Catalog->layer->title can inherit from mapsource->layer->title if you don't want to repeat yourself.

@brentfraser
Copy link
Contributor Author

I see your point. I was trying to put the Catalog label in a logical place (Catalog->layer->title) , but now my rules when creating mapbooks are:

  1. Add the title on the mapsource-layer
  2. If using multiple mapsource layers for one Catalog entry, put an additional title on the Catalog->layer

I'll have to test the multiple mapsource conditions. Thanks Jim!

@brentfraser
Copy link
Contributor Author

brentfraser commented May 25, 2021

so after a little testing:

The Catalog Label uses Catalog->layer->title. If not defined, it uses the first title found in the list of mapsources in the Catalog->layer-src definition. If no titles are found it uses an empty string. It never uses mapsource->layer->title.

The Select combo box (and Identify results) prefers mapsource->layer->title. If not defined it uses mapsource->title. If no titles on either, is uses an empty string (Identify shows "null" as a header).

So based on the above, the "best practice" is to use a title on the mapsource. I need to add that to the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants