Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and workflow for adding icons #243

Open
karenmajewicz opened this issue Jun 22, 2023 · 5 comments
Open

Update documentation and workflow for adding icons #243

karenmajewicz opened this issue Jun 22, 2023 · 5 comments
Assignees

Comments

@karenmajewicz
Copy link
Collaborator

We used to have a separate repo for icons here: https://github.com/geoblacklight/geoblacklight-icons

This repo is not archived, but we have been adding icons as SVG directly to the GeoBlacklight repo itself. Our documentation still includes mention of the https://icomoon.io and using geoblacklight-icons.json

@karenmajewicz karenmajewicz transferred this issue from geoblacklight/geoblacklight.github.io Oct 30, 2023
@ewlarson
Copy link
Member

ewlarson commented Feb 8, 2024

Reviewing this...

I still like IcoMoon and the geoblacklight-icons.json file. I'd vote to keep them in the application and our documentation. IcoMoon is very helpful for working with the SVG set as a whole.

We should archive the geoblacklight-icons repo. That hasn't been maintained for 5 years. I'll do that now.

@ewlarson
Copy link
Member

ewlarson commented Feb 8, 2024

GeoBlacklight Icons repo is now archived:
https://github.com/geoblacklight/geoblacklight-icons

@ewlarson
Copy link
Member

ewlarson commented Feb 8, 2024

Moving to "Review" for further discussion

@ewlarson
Copy link
Member

ewlarson commented Feb 8, 2024

To add:

  • Instructions for adding an icon to GBL proper (via PR)
  • Better description of how an icon is rendered inside the application for testing

@karenmajewicz karenmajewicz transferred this issue from geoblacklight/docs-archive Feb 8, 2024
@karenmajewicz karenmajewicz removed their assignment Aug 13, 2024
@ewlarson
Copy link
Member

Every icon in GBLv5 is a component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Planned
Status: No status
Status: Todo
Development

No branches or pull requests

2 participants