New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] homogeneous API response #199

Open

devagja opened this issue Feb 24, 2023 · 0 comments

devagja commented Feb 24, 2023

Hi all!
The response of the different endpoints are not homogeneous, I give an example.

https://api.genshin.dev/artifacts -> ["adventurer","archaic-petra",...] ✅
https://api.genshin.dev/characters -> ["albedo","aloy","amber",...] ✅
https://api.genshin.dev/characters/aloy -> {"name":"Aloy","title":"Savior From Another World",... ✅
https://api.genshin.dev/consumables -> ["food","potions"] ✅

https://api.genshin.dev/consumables/food -> {"pile-em-up":{"name":""Pile 'Em Up"",... ❌
I think it should be like this
https://api.genshin.dev/consumables/food -> ["pile-em-up","adeptus-temptation","adventurers-breakfast-sandwich",...] ✅

I understand the reason why you have created it this way,
but this complicates the API and this request optimization must be done in front

Is it possible to unify the response data structure?

Thx so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment