Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss naming of the Rx value returned from workflow #69

Open
jasonwalker80 opened this issue Dec 14, 2021 · 0 comments
Open

Discuss naming of the Rx value returned from workflow #69

jasonwalker80 opened this issue Dec 14, 2021 · 0 comments

Comments

@jasonwalker80
Copy link
Member

String rx_value = RxIdentifier.rx_value

I now see why I was somewhat confused on the original PR. The name for the value returned from the workflow is rx_value but the value returned is the estimated sex from the genome sequence data. One of the values in the TSV is the actual Rx value (a numeric, decimal value between 0-1). As discussed, the actual Rx value is ok to omit as a workflow output.

Instead of naming the workflow output as rx_value perhaps it should be named to rx_sex_estimate to avoid further confusion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant