Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors not reported by gorule-0000027 #2360

Open
4 of 5 tasks
pgaudet opened this issue Aug 30, 2024 · 0 comments
Open
4 of 5 tasks

Errors not reported by gorule-0000027 #2360

pgaudet opened this issue Aug 30, 2024 · 0 comments
Assignees

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Aug 30, 2024

  • FAILS GORULE:0000027 - TEST 6 - Prefix in column 1 ("WormBase") is a synonyms in /db-xrefs.yaml and IS REPAIRED

    WormBase WBGene00000002 aat-1 part_of GO:1990184 PMID:14668347 IPI WB:WBGene00000225 C GORULE_TEST:0000027-6 F27C8.1 gene taxon:6239 20131022 GO_Central

This is correctly repaired (resumably), but there is no message in the report saying that an error was found (and repaired)

  • ! FAILS GORULE:0000027 - TEST 7 - bad id syntax: WB needs 8 digits, has only 7

    WB WBGene0000002 aat-1 part_of GO:1990184 WB_REF:WBPaper00006408|PMID:14668347 IPI WB:WBGene00000225 C GORULE_TEST:0000027-7 F27C8.1 gene taxon:6239 20131022 GO_Central

Not detected

  • ! SHOULD PASS GORULE:0000027 - TEST 21 - WB_REF should be allowed

    WB WBGene00000002 aat-1 part_of GO:1990184 WB_REF:WBPaper00006408|PMID:14668347 IPI WB:WBGene00000225 C GORULE_TEST:0000027-21 F27C8.1 gene taxon:6239 20131022 GO_Central

WB_REF was missing from the db-refs.yaml last time we looked (2024-07-26). This test should not fail

  • ! FAILS GORULE:0000027 - TEST 14 - 'bad with' id syntax - should have 7 digits, has 8

- FB FBgn0020238 14-3-3epsilon involved_in GO:0006401 PMID:16931762 IGI FB:FBgn10004907 P GORULE_TEST:0000027-14 14-3-3epsilon 14-3-3|14-3-3 epsilon|14-3-3 protein epsilon protein taxon:7227 20220606 GO_Central

Incorrect regex is with not picked up, probably because Pascale incorrectly used FLYBASE as namespace in the original test. Test had been updated 2024-08-30, show now behave correctly.

  • WARNING - Invalid identifier:GORULE:0000027: FBrf0180198 does not match any id_syntax patterns for FB in dbxrefs--FB FBgn0024811 Crk involved_in GO:0048010 FB:FBrf0180198|PMID:15457211 IMP P GORULE_TEST:0000027-15 Crk oncogene CED-2|CG1587|CRK|D-CRK|D-Crk|DCrk|Dcrk|crk|dCRK|dCrk protein taxon:7227 20180912 GO_Central

Incorrectly picking up FBrf0180198 as not matching ID syntax pattern, but it's compliant with the syntax

@pgaudet pgaudet self-assigned this Aug 30, 2024
@pgaudet pgaudet assigned mugitty and unassigned pgaudet Aug 30, 2024
@pgaudet pgaudet moved this to In progress in GORULES (low-hanging fruit) Aug 30, 2024
mugitty added a commit that referenced this issue Sep 3, 2024
mugitty added a commit that referenced this issue Sep 3, 2024
mugitty added a commit that referenced this issue Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

2 participants