Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to support examining input and output annotation differences (GPAD 2.0 diffs?) #3687

Closed
sierra-moxon opened this issue Mar 17, 2021 · 8 comments
Assignees
Labels

Comments

@sierra-moxon
Copy link
Member

see: biolink/ontobio#540

@kltm @pgaudet

@kltm
Copy link
Member

kltm commented Mar 17, 2021

Noting, as a first step, we want to add functionality to ontobio to support gpad2.0 diffs to get a handle on this (biolink/ontobio#540).

@vanaukenk @ukemi @cmungall

@kltm kltm changed the title add functionality to ontobio to support gpad2.0 diffs Add functionality to ontobio to support GPAD 2.0 diffs Mar 17, 2021
@kltm
Copy link
Member

kltm commented Mar 17, 2021

Ah, the minerva repo has a lot of this stuff:
https://github.com/geneontology/minerva/issues?q=is%3Aissue+is%3Aopen+gpad
Should this actually be a separate sub-project? It looks like there might be a lot to do.

@kltm
Copy link
Member

kltm commented Mar 17, 2021

@ukemi @vanaukenk Would it be good to give a little more time to examining the current state of affairs with the output, and then you could iterate on the tools that are needed for automated probing of annotations w/@sierra-moxon?

@kltm kltm changed the title Add functionality to ontobio to support GPAD 2.0 diffs Add functionality to support examining input and output annotation differences (GPAD 2.0 diffs?) Mar 17, 2021
@sierra-moxon
Copy link
Member Author

sierra-moxon commented Mar 25, 2021

After talking with Chris:

  • calculate how many genes in each file, with how many unique terms per gene.
  • report if one file has significantly genes or unique terms.
  • use ontobio tools to see if missing terms are replaced with more general or more specific terms (for example, not needed in the first step).

Next steps will fall out as we progress.

@kltm
Copy link
Member

kltm commented Sep 24, 2021

After discussions with @cmungall and @sierra-moxon , @sierra-moxon will be prioritized to make a rough first pass on this, with @cmungall overseeing. As part of that discussion, it was placed into the GO-CAM GPAD Output project, but could also be handled as its own mini-project separately.

@sierra-moxon
Copy link
Member Author

PR is open for review here: biolink/ontobio#594
good for GAF 2.0 and GPAD 1.2 comparisons (but have to compare two of the same type/version).

@ValWood
Copy link
Contributor

ValWood commented Sep 11, 2023

Hi @sierra-moxon is this ticket still required?

@sierra-moxon
Copy link
Member Author

I think we can close; we have the differ in ontobio now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants