cfg-gated unsafe.

[vi]

Shall it handle #[cfg(feature=...)] and other optional unsafe code?

[anderejd]

Good question. I think there’s value in gathering unsafe stats without splitting the results per feature, but it could also be interesting to tag each unsafe usage with related cfg attributes. The scanning could always look for cfg attributes and allow optional presentation based on extra command line flags.

[vi]

I mean primarily making cargo geiger --all-features, cargo geiger --no-default-features work.

Currently it shows the same number regardless of --target or --features, at least for the root crate.

[anderejd]

I mean primarily making cargo geiger --all-features, cargo geiger --no-default-features work.

Ah, yes. That makes sense.

[pinkforest]

Repro

Using tokio/tokio as featuregate example

Using 0.11.2 straight from git

docker run -ti --rm rust /bin/bash

    cargo install cargo-geiger --git https://github.com/rust-secure-code/cargo-geiger --force
    mkdir app ; cd app
    git clone https://github.com/tokio-rs/tokio.git .
    cd tokio
    cargo geiger

nightly-x86_64-unknown-linux-gnu (default)
rustc 1.59.0-nightly (c5ecc1570 2021-12-15)

tokio/tokio
cargo geiger --no-default-features
23/136 1245/9291 73/189 1/17 61/286

cargo geiger --all-features
108/136 7453/9291 172/189 17/17 192/286

cargo geiger (it's nothing included by default)
23/136 1245/9291 73/189 1/17 61/286

cargo geiger --features fs
23/136 1251/9291 73/189 1/17 63/286

implementation wise It goes to cargo CompileOptions from_cli currently #226 but we are aiming to decouple

Closing as it's been resolved - re-opening if any issues that we can reproduce re: feature gate.

There were some other errors from tokio/tokio related to another issue I've linked that will track there.