From 479b2b4870d3d7878d85321a421ed5d8ad4b6b54 Mon Sep 17 00:00:00 2001
From: Alexandria <alexandria@gfsc.studio>
Date: Tue, 25 Jan 2022 14:57:40 +0000
Subject: [PATCH] Add tests

---
 .../admin/sites_integration_test.rb           | 21 ++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/test/integration/admin/sites_integration_test.rb b/test/integration/admin/sites_integration_test.rb
index 17596030d..ae8065310 100644
--- a/test/integration/admin/sites_integration_test.rb
+++ b/test/integration/admin/sites_integration_test.rb
@@ -35,10 +35,17 @@ class AdminSitesIntegrationTest < ActionDispatch::IntegrationTest
     assert_select 'label', 'Hero image'
     assert_select 'label', 'Hero image credit'
 
-    # See all neighbourhoods
-    assert_select '#site_neighbourhood_ids' do
-      assert_select 'option', @number_of_neighbourhoods
-    end
+    # See just neighbourhoods they admin
+    # In short:
+    # - Find the cocoon template for the Secondary Neighbourhoods <select> item
+    # - Grep for all occurences of "option value=" which grabs only the first <option> tag (not the closing tag)
+    # - That gives us all the neighbourhoods it is displaying
+    #
+    # Please replace this with Capybara in the future lol
+
+    cocoon_select_template = assert_select('.add_fields').first['data-association-insertion-template']
+    neighbourhoods_shown = cocoon_select_template.scan(/(option value=)/).size
+    assert neighbourhoods_shown == @number_of_neighbourhoods
   end
 
   test 'site admin users see appropriate fields' do
@@ -63,8 +70,8 @@ class AdminSitesIntegrationTest < ActionDispatch::IntegrationTest
     assert_select 'label', 'Hero image credit'
 
     # See just neighbourhoods they admin
-    assert_select '#site_neighbourhood_ids' do
-      assert_select 'option', 2
-    end
+    cocoon_select_template = assert_select('.add_fields').first['data-association-insertion-template']
+    neighbourhoods_shown = cocoon_select_template.scan(/(option value=)/).size
+    assert neighbourhoods_shown == 2
   end
 end