Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash Parasites slug #23

Open
martin-lueders opened this issue Apr 16, 2018 · 5 comments
Open

Splash Parasites slug #23

martin-lueders opened this issue Apr 16, 2018 · 5 comments

Comments

@martin-lueders
Copy link

Hi,

it seems you changed the slug from "SplashParasites" to "Splash Parasites".
Was that intended? Before editing my patches i was wondering whether you are planning to change it back?

In future, please try not to change the slugs. Names can be changed, though.

Cheers,
Martin

@gbrandt1
Copy link
Owner

Hi Martin,

Sorry i'm not sure what you mean.
The slugs for 0.6 are Southpole and Southpole-parasites, they didn't change.
If you are referring to the non-tagged master, i had to change the name of Splash
to Splash Parasite and changed the directory to Southpole also for the parasites
because I am not supposed to have two directories in the browser.
This change has not been released.

Cheers,
Gerhard

@martin-lueders
Copy link
Author

Hi Gerhard,

I got the latest update from the plugin-manager.

What happens is that I get the error message when opening an old patch, that the module "SplashParasites" cannot be found. When I look into the patch file of a new patch where I use the module, I see that it has the name (module slug) "Splash Parasites". So you must have introduced the space at some point. If this was deliberate, I will edit my old patches. For now I will wait for you next official release.

You should be able to change the plugin slug to combine the two plugins without having to change the module slug.

Cheers,
Martin

@martin-lueders
Copy link
Author

Edit: I saw now that the new (current) name is only "Splash" without the parasites at all. The plugin slug is "Southpole-Parasites", so I guess that's why you removed the "Parasites" from the Module slug.

Please, decide one ome way, and then try to keep it that way, as all changes invalidate old patches.

Cheers,
Martin

@gbrandt1
Copy link
Owner

hi martin,

my proposed solution is as outlined above:

the name (module slug) will be "Splash" and "Splash Parasites". (the alternative would be to invent yet another module name but i think so many different module names for variations of the same thing would be a bit silly...)

the directory name will be "Southpole" in both cases (in order to use a single directory in the browser).

and the plugin slugs will be Southpole and Southpole-parasites. i hope this flies. haven't tried to go through the build-team process yet.

the next release will be a clean-up release from which on i will try to keep things more stable as you request. ETA is unsure as i am very busy at work these days.

cheers,
gerhard

@martin-lueders
Copy link
Author

Hi Gerhard,

as far as I can see, your proposed solution is the wrong way around.

As all plugins just have the name "plugin.*" you can only have ONE plugin per directory.
If you want them to show up under the same "author" in the plugin browser, you can give them the same plugin slug and name.

So, to distinguish the two modules (e.g. Splash and Splash-Parasites) you need to give them different module slugs and names.

Just a stupid question: what prevents you from combining both the original and the parasites firmwares in the same module? Are there also differences between the modes which have the same name?

I dont have the hardware, so I dont know those details.

Cheers,
Martin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants