Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script error when pressing tab to complete #50

Open
eelcocramer opened this issue Oct 18, 2024 · 5 comments
Open

Script error when pressing tab to complete #50

eelcocramer opened this issue Oct 18, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@eelcocramer
Copy link

eelcocramer commented Oct 18, 2024

Describe the bug

When I use tab for auto completion an error occurs.

To Reproduce

Open a shell, press tab.

Expected behavior

The error not to occur.

Shell output

~/.config/fish/functions/_fifc_action.fish (line 29): array indices start at 1, not 0.
        if test -n "$$comp[$i][1]"
                            ^
in function '_fifc_action' with arguments 'source'
	called on line 1 of file ~/.config/fish/functions/_fifc.fish
in command substitution
	called on line 26 of file ~/.config/fish/functions/_fifc.fish
in function '_fifc'
~/.config/fish/functions/_fifc_action.fish (line 34): array indices start at 1, not 0.
        if test -n "$$comp[$i][2]"
                            ^
in function '_fifc_action' with arguments 'source'
	called on line 1 of file ~/.config/fish/functions/_fifc.fish
in command substitution
	called on line 26 of file ~/.config/fish/functions/_fifc.fish
in function '_fifc'
~/.config/fish/functions/_fifc_action.fish (line 46): array indices start at 1, not 0.
        set _fifc_extract_regex "$$comp[$i][7]"
                                         ^
in function '_fifc_action' with arguments 'source'
	called on line 1 of file ~/.config/fish/functions/_fifc.fish
in command substitution
	called on line 26 of file ~/.config/fish/functions/_fifc.fish
in function '_fifc'
~/.config/fish/functions/_fifc_action.fish (line 55): array indices start at 1, not 0.
        else if test "$action" = source; and test -n "$$comp[$i][5]"
                                                              ^
in function '_fifc_action' with arguments 'source'
	called on line 1 of file ~/.config/fish/functions/_fifc.fish
in command substitution

System (please complete the following information):

Using fish, version 3.7.1 on MacOS 15.0.1.

Additional context

I installed fifc using fisher. Error started to occur today. I'm updating the module daily using fisher update and it was working fine earlier this week.

@eelcocramer eelcocramer added the bug Something isn't working label Oct 18, 2024
@eelcocramer
Copy link
Author

When I install the version before the latest PR the error does not occur.

I.e. fisher install gazorby/fifc@1bc301453f674ed21fac4979c65a9a4cb7f2af61

@gazorby
Copy link
Owner

gazorby commented Oct 19, 2024

Does it occur once or every time you try to complete?

@eelcocramer
Copy link
Author

Yes

@tlvenn
Copy link

tlvenn commented Oct 29, 2024

exactly same thing happen on my end, same fish version with osx sonoma.

@hrvstr
Copy link

hrvstr commented Nov 3, 2024

Does it occur once or every time you try to complete?

For me, it happens every time I try to complete.

  • fish, version 3.7.1
  • fisher, version 4.4.5
  • macOS 14.7 (23H124)
  • Alacritty 0.14.0 (22a4475)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants