Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fifc removes a file using a wrapping function instead of with rm #45

Open
halostatue opened this issue Jul 5, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@halostatue
Copy link

In _fifc.fish:82, there is a bare rm … of the completion file generated. If you have a wrapping function (function rm; command grm --interactive --verbose $argv; end), this will be called, prompting for removal. Because the rm is in a completion function, there is no way to respond—and the completion file is not removed. This happens on every completion call (e.g., <Tab>).

This line should be command rm ….

@halostatue halostatue added the bug Something isn't working label Jul 5, 2024
@ollehu
Copy link

ollehu commented Oct 15, 2024

This PR #49 might solve this issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants