Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ros_gz_bridge action requires many of its arguments to be set even though they should be optional #554

Closed
azeey opened this issue May 30, 2024 · 0 comments · Fixed by #601
Assignees
Labels
bug Something isn't working

Comments

@azeey
Copy link
Contributor

azeey commented May 30, 2024

Part of #552

For example, the options container_name, namespace, and use_composition are optional in ros_gz_bridge.launch.py, but require a value when using <ros_gz_bridge> directly. It would be nice if the following worked:

<launch>
  <ros_gz_bridge   config_file='./ros_gz_bridge/test/config/minimum.yaml'  />
</launch>

or

<launch>
  <ros_gz_bridge 
    config_file='./ros_gz_bridge/test/config/minimum.yaml' 
    use_composition='True'/>
</launch>

If #553 is merged, we would have a name parameter in there as well since it will be required.

@azeey azeey added the bug Something isn't working label May 30, 2024
@azeey azeey moved this from Inbox to To do in Core development Jul 22, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Core development Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants