Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unvendor CLI11 since it is now shipped in all supported platforms #135

Open
azeey opened this issue Aug 20, 2024 · 1 comment
Open

Unvendor CLI11 since it is now shipped in all supported platforms #135

azeey opened this issue Aug 20, 2024 · 1 comment

Comments

@azeey
Copy link
Contributor

azeey commented Aug 20, 2024

CLI11 was vendored in #2 because it wasn't available in Ubuntu Focal. We can now unvendor it since it's available everywhere we support.

Platform version Link
Ubuntu Noble 2.4.1 https://packages.ubuntu.com/noble/libcli11-dev
Homebrew 2.4.2 https://formulae.brew.sh/formula/cli11
Windows vcpkg 2022 snapshot 2.1.2 https://github.com/microsoft/vcpkg/blob/2022.02.23/ports/cli11/vcpkg.json
Windows (conda) 2.4.1 https://anaconda.org/conda-forge/cli11
@traversaro
Copy link
Contributor

In theory it should be sufficient to set GZ_UTILS_VENDOR_CLI11 to OFF

gz-utils/CMakeLists.txt

Lines 25 to 28 in 6d794ba

option(
GZ_UTILS_VENDOR_CLI11
"If true, use the vendored version of CLI11, otherwise use an external one"
true)
.

@azeey azeey moved this from Inbox to To do in Core development Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

No branches or pull requests

2 participants