Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PosePublisher's "publish_nested_model_pose" parameter is confusing #2321

Open
azeey opened this issue Feb 21, 2024 · 0 comments
Open

PosePublisher's "publish_nested_model_pose" parameter is confusing #2321

azeey opened this issue Feb 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@azeey
Copy link
Contributor

azeey commented Feb 21, 2024

The PosePublisher system has a parameter for publishing the pose of the model that contains the plugin. This parameter is called publish_nested_model_pose:

/// - `<publish_model_pose>`: Set to true to publish model pose.
/// - `<publish_nested_model_pose>`: Set to true to publish nested model
/// pose. The pose of the model that contains this system is also published
/// unless publish_model_pose is set to false

However, anyone familiar with nested models in SDFormat would expect that the parameter is referring to publishing the pose of child (nested) models inside the model that contains the PosePublisher plugin.

I actually think this feature was a bug, but it has been used in many places, e.g. SubT, to provide ground truth. I propose we add a new parameter that allows just publishing the model's absolute pose (as opposed to relative to another parent model if it's nested) since that seems something a lot of users need (gazebosim/ros_gz#172, gazebosim/ros_gz#410).

Extra context:
#1342 added <publish_model_pose> that would allow users to disable publishing the pose of the top level model. i.e, if publish_model_pose=false and publish_nested_model_pose=true, the PosePublisher only publishes the child (nested) model poses.

@azeey azeey added the bug Something isn't working label Feb 21, 2024
@azeey azeey moved this from Inbox to To do in Core development Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

1 participant