Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should provide GZ_ADD_PLUGIN as an alias to IGNITION_ADD_PLUGIN and friends #133

Open
azeey opened this issue Nov 30, 2023 · 0 comments
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@azeey
Copy link
Contributor

azeey commented Nov 30, 2023

Desired behavior

It would be convenient to have GZ_ADD_PLUGIN in ign-plugin1 so we'd have less things to change when porting from Fortress to Garden

Alternatives considered

n/a

Implementation suggestion

Add aliases to Register.hh

#define GZ_ADD_PLUGIN(PluginClass, ...) \
  DETAIL_IGNITION_ADD_PLUGIN(PluginClass, __VA_ARGS__)

#define GZ_ADD_PLUGIN_ALIAS(PluginClass, ...) \
  DETAIL_IGNITION_ADD_PLUGIN_ALIAS(PluginClass, __VA_ARGS__)

#define GZ_ADD_FACTORY(ProductType, FactoryType) \
  DETAIL_IGNITION_ADD_FACTORY(ProductType, FactoryType)

#define GZ_ADD_FACTORY_ALIAS(ProductType, FactoryType, ...) \
  DETAIL_IGNITION_ADD_FACTORY_ALIAS(ProductType, FactoryType, __VA_ARGS__)
@azeey azeey added the enhancement New feature or request label Nov 30, 2023
@azeey azeey added the help wanted Extra attention is needed label Nov 30, 2023
@azeey azeey moved this from Inbox to To do in Core development Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: To do
Development

No branches or pull requests

1 participant