🧑‍🌾 CollectionTest/DownloadCollectionTest failing in Citadel Bionic, Windows and Homebrew

[Crola1702]

Environment

• OS Version: Ubuntu Bionic, Windows and Homebrew
• Source gz-fuel_tools4 bionic

Description

• Expected behavior: All test should pass
• Actual behavior: CollectionTest/DownloadCollectionTest tests are failing

Steps to reproduce

1. Run a build in gz-fuel_tools4 bionic or gz-fuel_tools4 windows
2. See tests fail

Output

Reference builds:

• https://build.osrfoundation.org/job/ign_fuel_tools-ci-ign-fuel-tools4-bionic-amd64/9/
• https://build.osrfoundation.org/job/ign_fuel-tools-ign-4-win/97/

Bionic test regressions:

CollectionTest/DownloadCollectionTest.AllItems/0
CollectionTest/DownloadCollectionTest.AllItems/1
CollectionTest/DownloadCollectionTest.AllItems/2
CollectionTest/DownloadCollectionTest.Models/0
CollectionTest/DownloadCollectionTest.Models/1
CollectionTest/DownloadCollectionTest.Models/2

Log output bionic:

7: [Dbg] [LocalCache.cc:598] Model [backpack] loading resource from another model, named [Backpack]. On Blueprint (ign-fuel-tools 3) and Citadel (ign-fuel-tools 4), [Backpack] is ignored. From Dome (ign-fuel-tools 5), [backpack] will be used. If [Backpack] is not a model belonging to owner [openrobotics], fix your SDF file!
7: [Dbg] [LocalCache.cc:598] Model [backpack] loading resource from another model, named [Backpack]. On Blueprint (ign-fuel-tools 3) and Citadel (ign-fuel-tools 4), [Backpack] is ignored. From Dome (ign-fuel-tools 5), [backpack] will be used. If [Backpack] is not a model belonging to owner [openrobotics], fix your SDF file!
7: [Msg] Finished, downloaded 2 models in total
7: /home/jenkins/workspace/ign_fuel_tools-ci-ign-fuel-tools4-bionic-amd64/ign-fuel-tools/src/gz_src_TEST.cc:463: Failure
7: Value of: common::isDirectory( common::joinPaths(this->testCachePath, "fuel.gazebosim.org", "openrobotics", "models", "backpack", "2"))
7:   Actual: false
7: Expected: true
7: /home/jenkins/workspace/ign_fuel_tools-ci-ign-fuel-tools4-bionic-amd64/ign-fuel-tools/src/gz_src_TEST.cc:466: Failure
7: Value of: common::isFile( common::joinPaths(this->testCachePath, "fuel.gazebosim.org", "openrobotics", "models", "backpack", "2", "model.sdf"))
7:   Actual: false
7: Expected: true
7: /home/jenkins/workspace/ign_fuel_tools-ci-ign-fuel-tools4-bionic-amd64/ign-fuel-tools/src/gz_src_TEST.cc:474: Failure
7: Value of: common::isDirectory( common::joinPaths(this->testCachePath, "fuel.gazebosim.org", "openrobotics", "models", "teambase", "2"))
7:   Actual: false
7: Expected: true
7: /home/jenkins/workspace/ign_fuel_tools-ci-ign-fuel-tools4-bionic-amd64/ign-fuel-tools/src/gz_src_TEST.cc:477: Failure
7: Value of: common::isFile( common::joinPaths(this->testCachePath, "fuel.gazebosim.org", "openrobotics", "models", "teambase", "2", "model.sdf"))
7:   Actual: false
7: Expected: true
7: [  FAILED  ] CollectionTest/DownloadCollectionTest.Models/2, where GetParam() = 16 (1717 ms)

Windows test regressions:

CmdLine.ModelListFail
CmdLine.ModelDownloadBadUrl
CmdLine.ModelDownloadWrongUrl
CmdLine.ModelDownloadUnversioned
CmdLine.DownloadConfigCache
CmdLine.WorldListFail
CmdLine.WorldDownloadBadUrl
CmdLine.WorldDownloadWrongUrl
CmdLine.WorldDownloadUnversioned
CollectionTest/DownloadCollectionTest.Worlds/0
CollectionTest/DownloadCollectionTest.Worlds/1
CollectionTest/DownloadCollectionTest.Worlds/2
CollectionTest/DownloadCollectionTest.AllItems/0
CollectionTest/DownloadCollectionTest.AllItems/1
CollectionTest/DownloadCollectionTest.AllItems/2
CollectionTest/DownloadCollectionTest.Models/0
CollectionTest/DownloadCollectionTest.Models/1
CollectionTest/DownloadCollectionTest.Models/2

Log output windows:

7: [ RUN      ] CollectionTest/DownloadCollectionTest.Worlds/2
7: C:\J\workspace\ign_fuel-tools-ign-4-win\ws\gz-fuel-tools\src\gz_src_TEST.cc(505): error: Value of: this->stdErrBuffer.str().empty()
7:   Actual: false
7: Expected: true
7: �[31m[Err] [C:\J\workspace\ign_fuel-tools-ign-4-win\ws\gz-common\src\Filesystem.cc:469] �[m�[31m[Err] [C:\J\workspace\ign_fuel-tools-ign-4-win\ws\gz-common\src\Filesystem.cc:469] �[m�[31m[Err] [C:\J\workspace\ign_fuel-tools-ign-4-win\ws\gz-common\src\Filesystem.cc:469] �[m�[31m[Err] [C:\J\workspace\ign_fuel-tools-ign-4-win\ws\gz-common\src\Filesystem.cc:469] �[m�[31m[Err] [C:\J\workspace\ign_fuel-tools-ign-4-win\ws\gz-common\src\Filesystem.cc:469] �[m
7: [  FAILED  ] CollectionTest/DownloadCollectionTest.Worlds/2, where GetParam() = 16 (950 ms)

This is related to: #340 and #370. But I can't figure out the fix right away 🤔

[mjcarroll]

Closed by #392