Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcheck needs to be updated to use c++17 #378

Closed
azeey opened this issue Aug 15, 2023 · 1 comment · Fixed by #404
Closed

cppcheck needs to be updated to use c++17 #378

azeey opened this issue Aug 15, 2023 · 1 comment · Fixed by #404

Comments

@azeey
Copy link
Contributor

azeey commented Aug 15, 2023

The version of cppcheck in Focal and later supports c++17, so we should update it.

gz-cmake/cmake/GzCodeCheck.cmake

Line 20 in 87c2a54

set (CPPCHECK_BASE -q --inline-suppr -j 4 --language=c++ --std=c++14 --force)

@azeey azeey moved this from Inbox to To do in Core development Aug 21, 2023
@Bi0T1N
Copy link
Contributor

Bi0T1N commented Aug 30, 2023

Also consider the <LANG>_CPPCHECK property of CMake 3.10 and newer. Example can be found here.

@sdhar04 sdhar04 mentioned this issue Jan 22, 2024
Merged
@azeey azeey closed this as completed in #404 Feb 1, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Core development Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cppcheck uses c++17 sdhar04/gz-cmake
2 participants
@azeey @Bi0T1N