Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Split Testing and Building into two actions #31

Open
FirefoxMetzger opened this issue Mar 24, 2021 · 1 comment
Open
Assignees

Comments

@FirefoxMetzger
Copy link

I just discovered this action, and I think it's really cool; being able to simply do

steps:
      [...]
      - name: Compile and test
        id: ci
        uses: ignition-tooling/action-ignition-ci@bionic
        with:
          codecov-token: ${{ secrets.CODECOV_TOKEN }}
      [...]

to get the ignition stack for CI testing seems so right and it would be very helpful if downstream packages (like ropy) can build on this functionality, too. That said, not every downstream package wants to run the whole test suite or upload ignition coverage, and merely building/adding ignition is all that is needed.

Would it be possible to split this action into two actions doing ignition-tooling/action-ignition-build and ignition-tooling/action-ignition-test?

@chapulina chapulina self-assigned this Apr 12, 2021
@chapulina
Copy link
Contributor

I think that for external projects, using prebaked Docker images may be more useful than this action.

You can try for example using the images from https://github.com/ignition-tooling/setup-ign-docker, which will have the latest Ignition code installed from source, and build your stuff on top of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants