Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp docker compose #485

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Revamp docker compose #485

merged 3 commits into from
Mar 7, 2024

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Mar 7, 2024

Ticket(s)

Closes #376

Description

In this PR I revamped the docker compose file by introducing a new intermediate service, which is an alpine image that runs the setup.sh script, which subsequently downloads GatewayD and plugins and installs them. The redis image is also added to make the cache plugin work as expected. GatewayD ports are exposed to make them available to the host machine.

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.
  • I have signed all the commits.

Legal Checklist

@mostafa mostafa merged commit 88b9d30 into main Mar 7, 2024
4 checks passed
@mostafa mostafa deleted the revamp-docker-compose branch March 7, 2024 23:55
smnmna99 pushed a commit that referenced this pull request Mar 13, 2024
* Use health check
* Add setup script for downloading and installing GatewayD and plugins
* Add intermediate service for installing plugins
* Use custom files for global and plugins configs
* Add Redis to be used by the cache plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp docker-compose.yaml
1 participant