Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Engine with Server #347

Closed
mostafa opened this issue Oct 17, 2023 · 0 comments · Fixed by #383
Closed

Merge Engine with Server #347

mostafa opened this issue Oct 17, 2023 · 0 comments · Fixed by #383
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.8.x

Comments

@mostafa
Copy link
Member

mostafa commented Oct 17, 2023

The Engine seems to be unnecessary now that the gnet/v2 is replaced by the net stdlib in #344. It would be better to merge the Engine with the Server code.
@mostafa mostafa added the enhancement New feature or request label Oct 17, 2023
@mostafa mostafa self-assigned this Oct 17, 2023
@mostafa mostafa added the good first issue Good for newcomers label Nov 1, 2023
@mostafa mostafa removed their assignment Dec 9, 2023
@snowAvocado snowAvocado mentioned this issue Dec 22, 2023
Merged
12 tasks
@mostafa mostafa moved this from ✨ New to 👀 In review in GatewayD Core Public Roadmap Dec 22, 2023
@mostafa mostafa linked a pull request Dec 22, 2023 that will close this issue
merge Engine with Server #383
Merged
12 tasks
@mostafa mostafa moved this from 👀 In review to 🔀 Merged in GatewayD Core Public Roadmap Dec 24, 2023
@mostafa mostafa added this to the v0.8.x milestone Dec 26, 2023
@mostafa mostafa moved this from 🔀 Merged to 🎉 Done in GatewayD Core Public Roadmap Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
GatewayD Core Public Roadmap
Status: 🎉 Done
Milestone
v0.8.x
Development

Successfully merging a pull request may close this issue.

merge Engine with Server snowAvocado/gatewayd
1 participant
@mostafa