Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add receive timeout #327

Closed
mostafa opened this issue Sep 20, 2023 · 0 comments · Fixed by #326
Closed

Add receive timeout #327

mostafa opened this issue Sep 20, 2023 · 0 comments · Fixed by #326
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mostafa
Copy link
Member

mostafa commented Sep 20, 2023

While I was adding benchmarks to the Client.Receive function, I found out that the function blocks forever, hence blocking the benchmark. This was also the case while testing GatewayD manually for long-running queries. So, I believe adding a timeout will stop the receive function from blocking the event loop, thus hanging the entire process and the message flow.

@mostafa mostafa self-assigned this Sep 20, 2023
@mostafa mostafa converted this from a draft issue Sep 20, 2023
@mostafa mostafa added the enhancement New feature or request label Sep 20, 2023
@mostafa mostafa added this to the v0.7.x milestone Sep 20, 2023
@mostafa mostafa changed the title Add receive timeout Add send/receive timeout Sep 20, 2023
@mostafa mostafa changed the title Add send/receive timeout Add receive timeout Sep 20, 2023
@mostafa mostafa mentioned this issue Sep 20, 2023
12 tasks
@mostafa mostafa moved this from ✨ New to 🚧 In progress in GatewayD Core Public Roadmap Sep 20, 2023
@mostafa mostafa closed this as completed Sep 20, 2023
@mostafa mostafa moved this from 🚧 In progress to 🔀 Merged in GatewayD Core Public Roadmap Sep 20, 2023
@mostafa mostafa linked a pull request Sep 20, 2023 that will close this issue
12 tasks
@mostafa mostafa moved this from 🔀 Merged to 🎉 Done in GatewayD Core Public Roadmap Sep 23, 2023
@mostafa mostafa mentioned this issue Sep 24, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant