Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise code by keeping the data in memory rather than saving to and loading from files #8

Open
garymooney opened this issue Feb 6, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@garymooney
Copy link
Owner

Currently almost all generated data are saved as files which are loaded later when generating the music and video. The video generation especially involves saving and loading many images.

It should be possible to avoid all of these files needing to be saved and loaded (except for the midi to wav conversion). Some of the files are actually useful to have saved (such as the wav file). However, the default behaviour should avoid saving and loading files in order for the qMuVi creation process to complete faster.

@garymooney garymooney added enhancement New feature or request good first issue Good for newcomers labels Feb 6, 2023
@garymooney
Copy link
Owner Author

In the recent major refactor, a lot of these situations were resolved. However when trying to avoid saving and loading pieces of the circuit diagram, I came across some issues with the Qiskit matplotlib circuit plotter. Changing the size of a matplotlib figure produced by the qiskit circuit plotter (either during fig creation or afterwards) does not resize the drawn circuit diagram in an expected way.

I'm not sure how to approach this, but I also don't think that it is important at the moment, especially since the other situations have already been fixed.

All that is left to do is delete the circuit pieces after they have been used for the video and double check if there are any methods that I missed that need to load qMuVi data from file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant