Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate random id_secret #18

Closed
mvdbeek opened this issue Apr 27, 2021 · 2 comments · Fixed by galaxyproject/planemo#1198
Closed

Generate random id_secret #18

mvdbeek opened this issue Apr 27, 2021 · 2 comments · Fixed by galaxyproject/planemo#1198
Labels
enhancement New feature or request

Comments

@mvdbeek
Copy link
Member

mvdbeek commented Apr 27, 2021

This should probably be an optional feature implemented in planemo and used in the action.
We use id_secret to encode integer primary keys, and these do change when running tests against a production server,
or when running tests in differently sized batches.

Sometimes (jbrowse for instance) these end up in the test data outputs, and will cause false positive test failures.
Similar idea for dates is implemented in #16

@mvdbeek mvdbeek added the enhancement New feature or request label Apr 27, 2021
@bernt-matthias
Copy link
Collaborator

Seems that to some extend planemo already implements setting id_secret https://github.com/galaxyproject/planemo/blob/4225e10dfffb6b67f528d3c1ac31664c741089af/planemo/galaxy/config.py#L457 .. adding a cli parameter seems trivial. I just don't get if / how planemo sets this for the test instance. A galaxy.yaml seems not to be generated.

@bernt-matthias
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants