Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool form does not update #16602

Closed
guerler opened this issue Aug 27, 2023 · 4 comments
Closed

Tool form does not update #16602

guerler opened this issue Aug 27, 2023 · 4 comments

Comments

@guerler
Copy link
Contributor

guerler commented Aug 27, 2023

Describe the bug
When switching datasets in tool forms associated dynamic parameters such as e.g. the column selector do not properly react to changes.

Galaxy Version and/or server at which you observed the bug
In current dev.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Merge Column' tool
  2. Select different tabular datasets
  3. Notice how the column selectors are not updated properly

Demo

Screen.Recording.2023-08-27.at.8.53.51.AM.mov
@mvdbeek
Copy link
Member

mvdbeek commented Sep 21, 2023

I think you fixed this in #16578 ?

@mvdbeek mvdbeek closed this as completed Sep 21, 2023
@guerler guerler reopened this Sep 23, 2023
@guerler
Copy link
Contributor Author

guerler commented Sep 25, 2023

This is still an issue, the fix I suggested was to restore the previous working condition but it was suggested to instead apply a fix which does not require copying the entire dict in order to restore reactivity which makes sense. This however has not been implemented yet.

xref: https://github.com/galaxyproject/galaxy/pull/14892/files#diff-1cacf7869df763d8e0724de99083e02000e5964f59cefe3faca1d646192b8a1cL168

@guerler guerler added major and removed major labels Sep 29, 2023
@dannon dannon moved this from Triage/Discuss to To Do, Assigned in UI/UX Working Group - weeklies Oct 24, 2023
@ElectronicBlueberry ElectronicBlueberry moved this from To Do, Assigned to In Progress in UI/UX Working Group - weeklies Oct 30, 2023
@ElectronicBlueberry
Copy link
Member

I can no longer reproduce this on dev.
@guerler could you please post an updated clip, if you can still reproduce this?

@guerler
Copy link
Contributor Author

guerler commented Nov 7, 2023

Fascinating, yes it does actually seem to be resolved. Might be related to the removal of the final legacy chunks related to the backbone-based form mechanism. Thank you for taking a look!

@guerler guerler closed this as completed Nov 7, 2023
@dannon dannon moved this from In Progress to Done in UI/UX Working Group - weeklies Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants