From f10ed72609a128af940a1565754ce75d2051f2e8 Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Tue, 10 Dec 2024 18:54:07 +0100 Subject: [PATCH] Fix target_type in auto-conversion context which means we collect and store the converted dataset as the job input. We don't need to wait for the galaxy.json collection, we know the exact target type already. That fixes the retrieval in `get_converted_files_by_type`. I believe this was always the intention and is how it works if the dataset already exists (i.e. on a re-run), and for all converters that don't use galaxy.json The converter records the dataset that the user chose, so there's no gap in the provenance either. This somewhat addresses https://github.com/galaxyproject/total-perspective-vortex/issues/141 so you can (reliably) differetiate your rules on the input datatype and filesize combination. --- lib/galaxy/datatypes/data.py | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/galaxy/datatypes/data.py b/lib/galaxy/datatypes/data.py index 05f5adbad6bf..225249413f1b 100644 --- a/lib/galaxy/datatypes/data.py +++ b/lib/galaxy/datatypes/data.py @@ -848,6 +848,7 @@ def convert_dataset( trans, incoming=params, set_output_hid=visible, history=history, flush_job=False ) for converted_dataset in converted_datasets.values(): + converted_dataset.extension = target_type original_dataset.attach_implicitly_converted_dataset(trans.sa_session, converted_dataset, target_type) trans.app.job_manager.enqueue(job, tool=converter) if len(params) > 0: