From 9a356c182aa2f2d5772a0cbee6969e898f263ba1 Mon Sep 17 00:00:00 2001 From: Nicola Soranzo Date: Tue, 24 Oct 2023 12:31:58 +0100 Subject: [PATCH] Remove unneeded/wrong parameters in method calls Fix the following mypy errors: ``` lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py:108: error: Unexpected keyword argument "filepath" for "commit_tar_to_repository" of "ShedTwillTestCase" [call-arg] self.commit_tar_to_repository( ^ lib/tool_shed/test/base/twilltestcase.py:1156: note: "commit_tar_to_repository" of "ShedTwillTestCase" defined here lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py:108: error: Unexpected keyword argument "valid_tools_only" for "commit_tar_to_repository" of "ShedTwillTestCase" [call-arg] self.commit_tar_to_repository( ^ lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py:108: error: Unexpected keyword argument "uncompress_file" for "commit_tar_to_repository" of "ShedTwillTestCase" [call-arg] self.commit_tar_to_repository( ^ lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py:108: error: Unexpected keyword argument "remove_repo_files_not_in_tar" for "commit_tar_to_repository" of "ShedTwillTestCase" [call-arg] self.commit_tar_to_repository( ^ lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py:108: error: Unexpected keyword argument "strings_not_displayed" for "commit_tar_to_repository" of "ShedTwillTestCase"; did you mean "strings_displayed"? [call-arg] self.commit_tar_to_repository( ^ lib/tool_shed/test/functional/test_0420_citable_urls_for_repositories.py:170: error: Need type annotation for "strings_not_displayed_in_iframe" (hint: "strings_not_displayed_in_iframe: List[] = ...") [var-annotated] strings_not_displayed_in_iframe = [] ^ ``` --- .../functional/test_0420_citable_urls_for_repositories.py | 2 -- ...est_1140_simple_repository_dependency_multiple_owners.py | 6 ------ 2 files changed, 8 deletions(-) diff --git a/lib/tool_shed/test/functional/test_0420_citable_urls_for_repositories.py b/lib/tool_shed/test/functional/test_0420_citable_urls_for_repositories.py index 8480013cafc4..e1c06b7732b6 100644 --- a/lib/tool_shed/test/functional/test_0420_citable_urls_for_repositories.py +++ b/lib/tool_shed/test/functional/test_0420_citable_urls_for_repositories.py @@ -167,7 +167,6 @@ def test_0025_load_view_page_for_previous_revision(self): if not self.is_v2: strings_displayed_in_iframe.append("Link to this repository revision:") strings_displayed_in_iframe.append(f"{self.url}/view/user1/filtering_0420/{first_changeset_hash}") - strings_not_displayed_in_iframe = [] self.load_citable_url( username="user1", repository_name="filtering_0420", @@ -176,7 +175,6 @@ def test_0025_load_view_page_for_previous_revision(self): encoded_repository_id=encoded_repository_id, strings_displayed=strings_displayed, strings_displayed_in_iframe=strings_displayed_in_iframe, - strings_not_displayed_in_iframe=strings_not_displayed_in_iframe, ) def test_0030_load_sharable_url_with_invalid_changeset_revision(self): diff --git a/lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py b/lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py index afe993c02af8..5df13e30b2e7 100644 --- a/lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py +++ b/lib/tool_shed/test/functional/test_1140_simple_repository_dependency_multiple_owners.py @@ -108,13 +108,7 @@ def test_0015_create_tool_repository(self): self.commit_tar_to_repository( repository, "blast/blastxml_to_top_descr.tar", - filepath=None, - valid_tools_only=True, - uncompress_file=True, - remove_repo_files_not_in_tar=True, commit_message="Uploaded blastxml_to_top_descr tarball.", - strings_displayed=[], - strings_not_displayed=[], ) def test_0020_verify_tool_repository(self):