From f3a554743eabdf07abb9d9a1248cb7ecdb34593a Mon Sep 17 00:00:00 2001
From: mvdbeek <m.vandenbeek@gmail.com>
Date: Mon, 20 May 2024 10:27:07 +0200
Subject: [PATCH 1/2] Trigger redirct before rendering form

---
 client/src/components/Tool/ToolSuccess.vue | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/client/src/components/Tool/ToolSuccess.vue b/client/src/components/Tool/ToolSuccess.vue
index 76a3613a7a25..befaa48e9b99 100644
--- a/client/src/components/Tool/ToolSuccess.vue
+++ b/client/src/components/Tool/ToolSuccess.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 import { BAlert } from "bootstrap-vue";
-import { computed, onMounted } from "vue";
+import { computed } from "vue";
 import { useRouter } from "vue-router/composables";
 
 import { useConfig } from "@/composables/config";
@@ -22,13 +22,10 @@ const responseVal = computed(() => jobStore.getLatestResponse);
 const showRecommendation = computed(() => config.value.enable_tool_recommendations);
 const toolName = computed(() => responseVal.value.toolName);
 
-/* lifecyle */
-onMounted(() => {
-    // no response means that no tool was run in this session i.e. no data in the store
-    if (Object.keys(responseVal.value).length === 0) {
-        router.push(`/`);
-    }
-});
+// no data means that no tool was run in this session i.e. no data in the store
+if (Object.keys(responseVal.value).length === 0) {
+    router.push(`/`);
+}
 </script>
 
 <template>

From 7444544cdbcdb9997daa94ac38f7879a41915d63 Mon Sep 17 00:00:00 2001
From: mvdbeek <m.vandenbeek@gmail.com>
Date: Mon, 20 May 2024 10:39:57 +0200
Subject: [PATCH 2/2] Fix undefined errors in ToolSucess component

The data is either present in the store if a user has actually submitted
or job,  or it is not. That includes both `jobDef` and `jobResponse`.
Followup to https://github.com/galaxyproject/galaxy/pull/18141.
---
 client/src/components/Tool/ToolSuccess.vue | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/client/src/components/Tool/ToolSuccess.vue b/client/src/components/Tool/ToolSuccess.vue
index befaa48e9b99..8ac04d5c4c4d 100644
--- a/client/src/components/Tool/ToolSuccess.vue
+++ b/client/src/components/Tool/ToolSuccess.vue
@@ -31,15 +31,15 @@ if (Object.keys(responseVal.value).length === 0) {
 <template>
     <section>
         <BAlert v-if="!jobResponse" variant="info" show>
-            <LoadingSpan message="Waiting on a job response" />
+            <LoadingSpan message="Waiting on data" />
         </BAlert>
         <div v-else>
             <div v-if="jobResponse?.produces_entry_points">
                 <ToolEntryPoints v-for="job in jobResponse.jobs" :key="job.id" :job-id="job.id" />
             </div>
             <ToolSuccessMessage :job-response="jobResponse" :tool-name="toolName" />
+            <Webhook type="tool" :tool-id="jobDef.tool_id" />
+            <ToolRecommendation v-if="showRecommendation" :tool-id="jobDef.tool_id" />
         </div>
-        <Webhook type="tool" :tool-id="jobDef.tool_id" />
-        <ToolRecommendation v-if="showRecommendation" :tool-id="jobDef.tool_id" />
     </section>
 </template>